Remove useless condition and simplify

whitequark / ast

A library for working with Abstract Syntax Trees.

MIT License

195 stars 25 forks source link

Remove useless condition and simplify #18

Closed marcandre closed 6 years ago

marcandre commented 6 years ago

I'm not sure what the original intent was, but clearly the && idx >= first_node_child is never going to make a difference. Indeed first_node_child is set to be the index of the first Node (or Array).

coveralls commented 6 years ago

Coverage decreased (-7.8%) to 92.157% when pulling 271654ae261dc3b6fdc6aca2da4ea0e38fd1bcd1 on marcandre:simplify into d89267dff580a58a74fbb1db8bd81e85c61f3ce9 on whitequark:master.

marcandre commented 6 years ago

Looks like a bug in coveralls. I removed a 8 lines (net) and coveralls seem to think that there are 8 lines not covered...