Add support for classfull IPv4

whitequark / ipaddr.js

IP address manipulation library in JavaScript

MIT License

570 stars 92 forks source link

Add support for classfull IPv4 #134

Closed Taiki-San closed 4 years ago

Taiki-San commented 4 years ago

Address issue https://github.com/whitequark/ipaddr.js/issues/133

whitequark commented 4 years ago

Looks like there's a three octet form too, see here.

Taiki-San commented 4 years ago

Indeed, Internet is a weird place... I feel like we probably could compact the three (four if we count the three octet form) codepath in one or two, but I'm not sure it's worth the time to avoid code duplication. Any strong feeling one way or another?

whitequark commented 4 years ago

Just duplicate it.

Taiki-San commented 4 years ago

Ok, just pushed support for 3 octet IPv4