search

whitequark / ipaddr.js

IP address manipulation library in JavaScript
MIT License
570 stars 92 forks source link

Add GitHub Actions Tagged Release #146

Closed kennethtran93 closed 3 years ago

kennethtran93 commented 3 years ago

Only if you want to use this.

This will, upon a new push of a tag matching a semver format (v[0-9]+.[0-9]+.[0-9]+) then it will do its tests, lint, build, and generate a new GitHub release, adding in the ipaddr.min.js file as an attachment. This only affect the GitHub Releases, which to this date shows 1.0.3 from 2015.

I've performed the test on my own repo, feel free to visit the forked repo and head into releases to see it.

As a side note, Not that there was anything wrong with putting that file at the root directory, but normally generated/minified files are not stored, and should be generated manually if they are cloning the repo as one may have forgotten to generate the minified build file with the added changes. That way people will know that the released min.js file under releases will work. We're humans, and sometimes what is committed to the master may not be working at all times.

Signed-off-by: Kenneth Tran kennethtran93@users.noreply.github.com

kennethtran93 commented 3 years ago

If you don't want this you can close it. However I'd suggest at least updating the GitHub Releases as well to the latest. It is currently sitting at 1.0.3 from 2015.

PS: I've slightly edited the first comment if you haven't checked it out yet.

whitequark commented 3 years ago

It is currently sitting at 1.0.3 from 2015.

I have no idea why there was a GH release for 1.0.3; I just deleted that.

whitequark commented 3 years ago

I haven't used Node.js for many years so I'd rather not change anything radically.

kennethtran93 commented 3 years ago

I haven't used Node.js for many years so I'd rather not change anything radically.

It won't change anything at all - this just allows additional package publishing through github releases.

Also with your package having over 10 million downloads (at least on npm), you should consider updating the versions or letting somebody else assist you in that aspect as some of the bugs have been fixed through this repo.

whitequark commented 3 years ago

Published 2.0.0.