whitequark / ipaddr.js

IP address manipulation library in JavaScript
MIT License
570 stars 92 forks source link

Dev test #177

Closed msimerson closed 3 months ago

msimerson commented 3 months ago
msimerson commented 3 months ago

Several changes here:

msimerson commented 3 months ago

naming files with *.test.js and putting them next to the files they test is apparently a pattern.

Something I just thought of and don't like, is that putting the test file in lib publishes it on npm. That's a small deal, but with 36m weekly downloads, the smallness has a very large multiplier. I've talked myself out of it. 😲 Sorry for the noise.

Note to self: the NPM docs say that putting a .npmignore in a subdirectory will override [files], so one could echo '*.test.js' > lib/.npmignore. With dozens of npm modules that (still) use the ./test/ convention, I'm not yet convinced.

whitequark commented 3 months ago

Thanks!