search

whitequark / parser

A Ruby parser.
Other
1.59k stars 199 forks source link

Doc: RemoveDo is incomplete #1034

Open akimd opened 3 months ago

akimd commented 3 months ago

Hi,

That's a very minor detail, but it might be worth fixing for sake of newcomers. The RemoveDo example does not recurse in the body of while loops, so it fails to process nested loops.

Adding a super should suffice.

Cheers!

akimd commented 3 months ago

(Also, FWIW, using <<-RUBY rather than EOF is more conformant to RuboCop's recommended practice.)

akimd commented 3 months ago

Also, the doc pointed to, https://whitequark.github.io/parser/, is completely outdated. Maybe it could be updated automatically using GitHub actions?