search

whitequark / parser

A Ruby parser.
Other
1.58k stars 198 forks source link

ruby/ruby@d746a41 #593

Open iliabylich opened 5 years ago

iliabylich commented 5 years ago

https://github.com/ruby/ruby/commit/d746a41e85b746a90eef20c46d24880fe084ffc5

iliabylich commented 5 years ago

@whitequark this commit adds a parsing error on ?\u{41 42}. Ruby had this error from the very beginning, but 2.5 had a bug and so it's a valid syntax for 2.5 and 2.6. However, all versions of parser reject it. Should we backport this bug? I think it's fine to keep it as is.

The fix wasn't backported into 2.5/2.6 MRI branches

whitequark commented 5 years ago

Seems fine to ignore this, with a README mention like usual.