search

whitequark / parser

A Ruby parser.
Other
1.59k stars 199 forks source link

warn_syntax_deviation: call `warn` only once #834

Closed casperisfine closed 2 years ago

casperisfine commented 2 years ago

Calling warn 3 times is very annoying for warning management tools that define Warning.warn, they're seen as 3 distinct warning instead of a single one.

cc @paracycle

casperisfine commented 2 years ago

Thanks @iliabylich !

iliabylich commented 2 years ago

Thanks. Please, let me know if you'd like it to be released now. Otherwise it'll be a part of 3.2 post-Christmas release

casperisfine commented 2 years ago

Nah, it has been like this for years, it can wait the next update.