+ Ruby 3.3 support - Githubissues

whitequark / parser

A Ruby parser.

Other

1.59k stars 198 forks source link

+ Ruby 3.3 support #904

Closed olefriis closed 1 year ago

olefriis commented 1 year ago

I've basically mimicked #841.

Copied lib/parser/ruby32.y to lib/parser/ruby33.y, editing the version number on the first line. Since Ruby 3.2 was released a couple of weeks ago, the grammars are probably identical for now (?).
Other changes similar to #841.
Added a changelog entry. As I understand the version number specs for this repo, adding Ruby 3.3 support means bumping a "minor" version. I have not bumped the version in lib/parser/version.rb, as I suppose this will be part of the actual release process. Also, since I do not know when the version will be released, I haven't added a timestamp in the changelog.

olefriis commented 1 year ago

Thanks for the extremely quick feedback, @iliabylich. I've applied the suggested changes, except the one about the parser_for_ruby_version needing to handle 3.3. That should already be there, right?

iliabylich commented 1 year ago

Thanks!

nickborromeo commented 1 year ago

👋 @iliabylich can I ask when this change is going to be scheduled to be released as a patch version for the gem? 🙇

iliabylich commented 1 year ago

I don't plan to release until Ruby 3.2.1 (i.e. with release of the next Ruby version) or in case of a bugfix (that would be parser 3.2.0.1).

Why do you need this change?

nickborromeo commented 1 year ago

We have a running branch every week to test Ruby and the sha that we are targeting is 9726736006b3f74635fd8af05814fe0908e2cf84 which contains this change for the versions

It looks like there are other gems like rubocop-ast and rubocop that rely on this, right now we are just trying to get a timeline of things; which you have already provided since you are planning to release when Ruby 3.2.1 comes out.