Closed koic closed 1 year ago
Ah, now it makes sense, I completely missed the fact that it's a dev dependency 🤦 . That's where the difference between parser's and rubocop's test suites come from.
Is it safe to specify no version constraint for racc?
Honestly, I'm not entirely confident. However, given that there has never been a specific runtime version required for Racc, I believe it is least likely to encounter incompatibilities.
Good point 👍
3.2.2.3
has been released. Could you check if works with RuboCop please?
@iliabylich I opened https://github.com/rubocop/rubocop/pull/11942 using Parser 3.2.2.3 with RuboCop and the Ruby 3.3.0dev CI matrices are successful. Thanks for the quick release!
@koic @iliabylich I appreciate this work. Thanks!
Follow up https://github.com/ruby/ruby/pull/7877.
Ruby 3.3.0dev is set to promote Racc to a bundled gem. Therefore, this PR adds Racc to runtime dependencies to prevents the following error in RuboCop:
https://app.circleci.com/pipelines/github/rubocop/rubocop/9387/workflows/c308ef87-1373-4c0a-b90d-a22ea57860e3/jobs/279345
Since the Parser gem supports Ruby 2.0.0 and above, So, Racc runtime version is not specified to accept older Racc versions. Development version of Racc 1.7.0 has been added to the Gemfile.