Raise a more specific error when encountering an unknown magic comment encoding

whitequark / parser

A Ruby parser.

Other

1.59k stars 199 forks source link

Raise a more specific error when encountering an unknown magic comment encoding #999

Closed Earlopain closed 8 months ago

Earlopain commented 8 months ago

Closes #998

Let me know if I should tweak the docs for the exception in some way.

I also know that this library still targets Ruby 2.0. CI only seems to test against somewhat recent versions. I used the old begin/end syntax since I know that omitting the begin was added somewhere between but other than that I haven't tested on older versions.

iliabylich commented 8 months ago

Let me know if I should tweak the docs for the exception in some way.

Looks good to me. Thank you very much!