Closed sw17ch closed 12 years ago
The pull request seems to work fine on Debian. I'll add a bit more stuff and release a new version of gem.
By the way, I noticed that rlua is licensed under LGPL3, for historical reasons. I'm going to relicense it under MIT. Do you allow me to redistribute your contribution under that license, too?
Yes. Absolutely.
The beta gem fails to install on windows, but fails silently:
C:\Users\Administrator>gem install rlua -v 1.1.beta1
Successfully installed rlua-1.1.beta1
1 gem installed
Installing ri documentation for rlua-1.1.beta1...
Installing RDoc documentation for rlua-1.1.beta1...
C:\Users\Administrator>pry
[1] pry(main)> require 'rlua'
LoadError: cannot load such file -- rlua.so
from C:/Rubies/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in
`require'
[2] pry(main)>
I haven't had a chance to do too much more investigation, but we noticed that the log file somehow fails to find the newstate
symbol (which is a problem in and of itself). More importantly, it appears that if the checks/compilation fails, the gem doesn't fail to install.
Hmm, not surprising -- it was never supposed to work on Windows. I don't have a Windows system anyway, so you're on your own. I guess that you just don't have Lua headers/libs installed.
I noticed that RLua fails to install with the current version of Lua on Homebrew (5.1.4). Following is the error I get when trying to install. Several variations of the options also failed.
These commits do a few things, but mainly:
.
before the version number in extconf.rb#include <lua.h>
instead of#include <lua5.1/lua.h>
.I'm not sure if #2 above is preferable. After making the changes in this pull request, running the following command manages to install the gem: