search

whitesmith / WSTagsField

An iOS text field that represents tags, hashtags, tokens in general.
MIT License
1.28k stars 226 forks source link

Feature Request: Ability to select multiple tags at a time #100

Open michaeltheshah opened 6 years ago

michaeltheshah commented 6 years ago

Which version of the WSTagsField are you using?

3.1.0

On which platform does the issue happen?

E.g. iOS11

Are you using Carthage?

No

Are you using Cocoapods?

1.4.0

Which version of Xcode are you using?

Xcode 9.4.1

What did you do?

I'm trying to allow multiple tags to be selected. What I have tried to do is override selectTagView(_ tagView: WSTagView, animated: Bool) in order to simply toggle the selected state of the tagView, but it seems like even when removing the block to unselect all of the other tags...

tagViews.filter { $0 != tagView }.forEach { $0.selected = false onDidUnselectTagView?(self, $0) } ...they all still get unselected.

What did you expect to happen?

Multiple tags to be selected

What happened instead?

They seem to all get unselected and then the tag the user selected is shown.

michaeltheshah commented 6 years ago

Looks like the first culprit is resignFirstResponder(). I commented out the selected = false and it allows multiple selections. Now to unselect...

michaeltheshah commented 5 years ago

@ricardopereira Any update to this? It's been awhile

ricardopereira commented 5 years ago

@mochat97 I have no time available to implement this. Can you fork and do the change please? I can review it. Thanks

michaeltheshah commented 5 years ago

Done