whitespace-se / storybook-addon-html

A Storybook addon that extracts and displays compiled syntax-highlighted HTML
Other
95 stars 43 forks source link

Peer dependency incompatibility with storybook v7 #96

Closed sovanyio closed 5 months ago

sovanyio commented 1 year ago

Haven't extensively tested it in v7, but fixing the peer dep locally with || ^7.0.0 and updating the preset.js as follows works to get a working HTML tab:

function previewAnnotations(entry =[]) {
  return [...entry, require.resolve("./dist/esm/preset/preview")];
}

function managerEntries(entry = []) {
  return [...entry, require.resolve("./dist/esm/preset/manager")];
}

module.exports = {
  managerEntries,
  previewAnnotations,
};
robg-makemusic commented 1 year ago

Please fix this, we can't update to Storybook 7 because of this

volnei commented 1 year ago

Same here!!!

legobeat commented 1 year ago

Suggestion from @sovanyio ported to #97

@robg-makemusic @volnei does this patch work for you?

jeanfredrik commented 1 year ago

97 has been merged now. Let me know if you have any further issues. Sorry for keeping you waiting.