search

whitespacecode / nova-table-card

Nova Card for Custom Tables
MIT License
9 stars 4 forks source link

Introduce nova-kit/nova-packages-tool #2

Open webard opened 2 months ago

webard commented 2 months ago

This PR introduces nova-kit/nova-packages-tool, which reduces the size of production card.js from 157 KB to 11.5 KB.

whitespacecode commented 2 months ago

Hi @webard thank you for your pull request. I have tested the request and notice a bug.

TypeError: Cannot read properties of undefined (reading 'props')
    at li (runtime-core.esm-bundler.js:4218:20)
    at r (runtime-core.esm-bundler.js:4225:29)
    at Array.forEach (<anonymous>)
    at li (runtime-core.esm-bundler.js:4237:19)
    at xa (runtime-core.esm-bundler.js:7464:19)
    at O (runtime-core.esm-bundler.js:5889:48)
    at V (runtime-core.esm-bundler.js:5874:9)
    at w (runtime-core.esm-bundler.js:5342:11)
    at B (runtime-core.esm-bundler.js:5590:7)
    at C (runtime-core.esm-bundler.js:5497:7)

I'm using the nova-table-card as a Card on my Dashboard.

class Main extends Dashboard
{
    public function cards()
    {
        return [
            new LatestConfigurations,
        ];
    }

    public function name()
    {
        return 'Dashboard';
    }
}
webard commented 2 months ago

Hmm, I can’t reproduce this issue. I’m using this package in several places (dashboards and as a card in resources), and all of them are working fine, without any error.