fix: numpy required before setup

whitews / FlowUtils

FlowUtils is a Python package containing various utility functions related to flow cytometry analysis, primarily focused on compensation and transformation tasks commonly used within the flow community.

https://flowutils.readthedocs.io

BSD 3-Clause "New" or "Revised" License

14 stars 8 forks source link

fix: numpy required before setup #8

Closed DavHau closed 3 years ago

DavHau commented 3 years ago

Requiring any dependencies before calling setuptools should always be avoided.

Please also look into releasing wheels. The sdist/setup.py installation method is from ancient times. It doesn't have a proper standard for metadata and executes code from within the package during installation. This is undesirable for any modern package management scenarios.

whitews commented 3 years ago

@DavHau Thanks for the PR and the info. A long while back I tried adding setup_requires to setup.py but it didn't seem to work. Not sure what the issue was but this is working. I'll look into modernizing the packaging for these flow libraries. Thanks again!