Add table_type option for :set and :ordered_set

whitfin / cachex

A powerful caching library for Elixir with support for transactions, fallbacks and expirations

https://hexdocs.pm/cachex/

MIT License

1.54k stars 97 forks source link

Add table_type option for :set and :ordered_set #331

Closed camilleryr closed 6 months ago

camilleryr commented 6 months ago

This fixes #328.

I didn't put too much thought into any of the documentation, so feel free to make any changes you would like to see! Thanks again for all your work on this. Chris

whitfin commented 6 months ago

This looks fine, although I would prefer if the option were simply ordered: true with the default being false (exactly how :compressed is handled).

If you'd like to update that, then I'm happy to merge - or I'm happy to merge and make the changes after. Up to you, Thank you!

camilleryr commented 6 months ago

That makes sense to me - I think bag / duplicate_bag change the semantics of the storage enough that they don't make a ton of sense as options, so the boolean flag seems good! I have updated this PR accordingly.