Replaced :slave with :peer.

whitfin / local-cluster

Easy local cluster creation for Elixir to aid in unit testing

MIT License

226 stars 30 forks source link

Replaced :slave with :peer. #28

Closed alfetahe closed 2 months ago

alfetahe commented 1 year ago

The old :slave module is deprecated and will be removed from OTP 27. I replaced the :slave module with the :peer module. I fixed the tests. This change is not backward compatible because the :peer module starts {:ok, pid, peer} where pid is used to shutdown the peer nodes and peer is used as the node name. Meaning the start_nodes/3 function should also include the pid from now on.

whitfin commented 10 months ago

@alfetahe this looks good; is it possible for us to tweak the signatures to support both :slave and :peer and dispatch dynamically based on OTP version? I don't want to enforce OTP 25+ for this lib just yet.

whitfin commented 2 months ago

This is being superseded by #30. Thank you for your time spent here!