search

whitlockjc / json-refs

Various utilities for JSON Pointers (http://tools.ietf.org/html/rfc6901) and JSON References (http://tools.ietf.org/html/draft-pbryan-zyp-json-ref-03).
MIT License
226 stars 64 forks source link

Cannot build and test in node 12.7.0 on master branch #167

Closed JacobHarvey94 closed 5 years ago

JacobHarvey94 commented 5 years ago

Running Gulp on the master branch gives the following error:

const { Math, Object } = primordials;
                         ^

ReferenceError: primordials is not defined
    at fs.js:27:26
    at req_ (/Users/jharvey/Desktop/third-party-repos/json-refs/node_modules/natives/index.js:143:24)
    at Object.req [as require] (/Users/jharvey/Desktop/third-party-repos/json-refs/node_modules/natives/index.js:55:10)
    at Object.<anonymous> (/Users/jharvey/Desktop/third-party-repos/json-refs/node_modules/vinyl-fs/node_modules/graceful-fs/fs.js:1:37)
    at Module._compile (internal/modules/cjs/loader.js:777:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:788:10)
    at Module.load (internal/modules/cjs/loader.js:643:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Module.require (internal/modules/cjs/loader.js:683:19)
    at require (internal/modules/cjs/helpers.js:16:16)

On the latest recommended release of node(10.16.1) tests pass fine.

This has stopped the merge of my pull request updating js-yaml to 3.13.1 to fix a vulnerability: https://github.com/whitlockjc/json-refs/pull/166

whitlockjc commented 5 years ago

This is a duplicate of #164. I'll get on it.

JacobHarvey94 commented 5 years ago

Thanks :)