search

whitlockjc / json-refs

Various utilities for JSON Pointers (http://tools.ietf.org/html/rfc6901) and JSON References (http://tools.ietf.org/html/draft-pbryan-zyp-json-ref-03).
MIT License
223 stars 63 forks source link

- Refactoring: Remove superfluous argument #168

Closed brettz9 closed 4 years ago

brettz9 commented 4 years ago

Just a small item came across in my monitored projects (at https://lgtm.com/projects/g/whitlockjc/json-refs/?mode=list ).

whitlockjc commented 4 years ago

LGTM, will merge soon. Thanks!

whitlockjc commented 4 years ago

How did you find this? 👍

brettz9 commented 4 years ago

Take a look at https://lgtm.com ... I added the projects I use to my dashboard, including indicating your Github URL, and they listed and linked to your alerts page at https://lgtm.com/projects/g/whitlockjc/json-refs/?mode=list . They do some great analysis missed out even by eslint, particularly useful I've found for finding security bugs though that wasn't the case here.

whitlockjc commented 4 years ago

That's very cool.

brettz9 commented 4 years ago

They also have a Github integration, so one can use lgtm to auto-check PRs: https://lgtm.com/help/lgtm/github-apps-integration