modernize build test and lint

whitlockjc / json-refs

Various utilities for JSON Pointers (http://tools.ietf.org/html/rfc6901) and JSON References (http://tools.ietf.org/html/draft-pbryan-zyp-json-ref-03).

MIT License

223 stars 63 forks source link

modernize build test and lint #185

Open chris-armstrong opened 3 years ago

chris-armstrong commented 3 years ago

This is a PR to modernize the build and test infrastructure, including:

using preconstruct to generate ESM and commonjs compatible exports for bundling
removing the use of gulp and replacing with npm scripts
upgrading packages to address security warnings

whitlockjc commented 3 years ago

First off, thanks a ton for taking this on. I'll review this more in depth ASAP.

chris-armstrong commented 3 years ago

I should note that I'm no longer depending on these changes to make further additions, so I won't be chasing these up, but they may be useful to anyone consuming the library or submitting PRs.

whitlockjc commented 3 years ago

@chris-armstrong Thanks again for doing this, and if you're still willing to help me get this ready to merge, I'd love to use it. I know you said you don't depend on this anymore but I think the changes you're suggesting could be welcome. Where does this PR stand in your opinion? Also, do you mind updating CONTRIBUTING.md to reflect the new build/release process?

chris-armstrong commented 3 years ago

I don't have anything I want to add to this PR, but because it's been a couple of months, and I'm not using the changes, I think best next step is to verify it hasn't regressed for downstream consumers of the module.

I'd say the next steps is to:

resolve outstanding merge conflicts
build and release as an alpha version on npm so that it can be upgraded in downstream projects to test compatibility
update CONTRIBUTING.md to reflect new build process (npm run build)