whitmanarchive / whitman-LG_1855_variorum

Data Repo for in progress variorum
0 stars 0 forks source link

Use js to fix overstrike display for mss #60

Closed nichgray closed 5 years ago

nichgray commented 5 years ago

We'll need to add something in the javascript to deal with overstrikes that happen with supralinear additions. Right now all such situations should include a .noline class marking the segment where we want the non-supralinear overstrike NOT to appear.

An example of how this looks is:

Screen Shot 2019-07-29 at 11 49 44 AM

Two examples of the incorrect display are lines 3 and 14 in the variorum:

Screen Shot 2019-07-29 at 4 24 18 PM

(we want no lower strikethrough on the word "my")

Screen Shot 2019-07-29 at 4 24 27 PM

(we want no lower strikethrough on the words "Branched" and "crotch")

nichgray commented 5 years ago

We've lost an "a" in here, I think (from relation next to "The pride of the United States..."):

Screen Shot 2019-08-02 at 11 50 39 AM

Should look like:

Screen Shot 2019-08-02 at 11 51 30 AM

(see between "the" and "breed")

nichgray commented 5 years ago

We're also losing a few insertion marks here and there. From line connected to "These understand the law":

Screen Shot 2019-08-02 at 12 01 09 PM

Should be:

Screen Shot 2019-08-02 at 12 01 26 PM

(See between "yet" and "still")

nichgray commented 5 years ago

One case where the overstrike is still there. From line connected to "and all their stifling deceits":

Screen Shot 2019-08-02 at 12 13 46 PM

Shd be:

Screen Shot 2019-08-02 at 12 14 40 PM

(see "sliding")

jduss4 commented 5 years ago

@nichgray the problem with that final "and all their stifling deceits" one is that the span class on sliding is just supralinear instead of both supralinear and overstrike, which I had been assuming all of them would be if it needed to be both. I'm guessing, though I haven't checked, that we might need to change the manuscript TEI to match how other cases of that are marked?

jduss4 commented 5 years ago

I have been informed that I may not change the TEI, and so I shall myself practice flexibility :)

nichgray commented 5 years ago

So many "undefined"s! This is linked from the line "It cannot be varied by statutes any more than love or pride or the attraction of gravity can," (2300 in display)

Screen Shot 2019-08-06 at 10 24 03 AM
nichgray commented 5 years ago

Here is another. Seems to be occurring with subst?

Screen Shot 2019-08-06 at 10 29 46 AM
nichgray commented 5 years ago

IT IS FIXED HOLY COW nicely done @jduss4

jduss4 commented 5 years ago

It only took me like 7 tries! :D