whitmer / canvabadges

MIT License
29 stars 14 forks source link

Adding I18n to canvabadges #12

Open Kulgar opened 9 years ago

Kulgar commented 9 years ago

Hello Whitmer,

Here is the pull request adding i18n mechanisms.

Some notes about it:

I don't want this pull request to be to difficult for you to merge in your project, so, let me know if you need me to do anything to help you.

Regis.

whitmer commented 9 years ago

Hi Regis, thanks for doing this. I opted to include only the i18n code and a couple of the translations for now. The full .yml files are merged in, but I'd feel more comfortable applying the translations in a separate step. I'll try to get to this soon-ish, but if you have some time it'd help if you'd do each .erb file as a separate commit so I can more easily see what's going on.

Thanks for spear-heading this!