Implemented month onChange to set the day count

whitphx / react-ymd-date-select

Hooks and components for Y-M-D dropdowns with React

MIT License

45 stars 6 forks source link

Closed Trystanr closed 1 year ago

Trystanr commented 1 year ago

Hi @whitphx

Thanks for the awesome package.

I noticed the package does not check for days of the month so I have added it.

I have only completed the implementation for the vanilla preset, but the other presets should be super simple.

This would close #20

Hope it helps!

whitphx commented 1 year ago

Thank you for having an interest in and contributing to this repository, but let me reject this suggestion due to the following reasons.

Checking the number of days on each month has been done inside useDateSelect() and the invalid combinations of Y/M/D are represented with null value of the dateValue field returned from useDateSelect(), so it should not be done at the view component layer.
Logics should be inside the hook, not in the view component.

Thank you for your understanding.