search

whittle-org / whittle

Python library to compress LitGPT models for resource efficient inference.
https://whittle-org.github.io/whittle/latest/
Apache License 2.0
10 stars 4 forks source link

fixed type hints #163

Closed zeqri closed 1 week ago

zeqri commented 1 week ago

Fix type hints to make docs happy #114

I made changes such that warnings related to type hints no longer appear when running : mkdocs build --clean --strict

I still have to do the second part.

@timurcarstensen

timurcarstensen commented 1 week ago

Thanks a lot for picking this up! :)

I notice that some of our automatic formatting rules have not been applied to your changes. Could you make sure that you install the pre-commit hooks (cf. CONTRIBUTING.md)? Also, it seems that you haven't created your dev branch from the most up-to-date version of the main branch (i.e., git pull --ff before git branch) which is why our GitHub Actions workflows for testing and formatting aren't running. Could you make sure to merge the main branch into your development branch to get all the latest changes? If you have any questions feel free to reach out to me here or via Mattermost :)