whittlem / pycryptobot

Python Crypto Bot (PyCryptoBot)
Apache License 2.0
1.97k stars 738 forks source link

Optional config option for EMA numbers #266

Open oestevan8 opened 3 years ago

oestevan8 commented 3 years ago

Describe the solution you'd like For example, for the "config" options:

"emabuy" : 12, 26, "emasell": 8, 12, .. Thank you

whittlem commented 3 years ago

Why the shorter moving average on the sell? Is it to detect the change faster?

whittlem commented 3 years ago

I've added "ema8" to the data frame and the crossovers with "ema12" which already existed. They are called "ema8gtema12", "ema8gtema12co", "ema8ltema12", and "ema8ltema12co". I've not done any integration into the bot yet because it's quite a lot of work and I need to see how many others want to to determine priority.

If you want to try the feature now just do a find and replace in pycryptobot.py for "ema12ltema26co" with "ema8ltema12co". That is the quick way to try your feature out now.

oestevan8 commented 3 years ago

I did hundreds of test on TradingView with different EMA indicators, and by changing EMA sell and buy signal numbers, many times I get slightly better result. For each bot I start I would use different numbers according to test result. (Those 8, 12 are just example, probably not the best for a sell signal). I'll try your suggestion, thank you!

yanone commented 3 years ago

If this comes to pass as a setting, I would like to appeal to make the new setting a default for Binance, and the old settings optional, if they are indeed found by you and the other trading experts to be beneficial.

Personally, I’m not a trading expert, so I just want to generally appeal to make as much trading intelligence as possible (and improvements thereof) a default functionality rather than optional.