whittlem / pycryptobot

Python Crypto Bot (PyCryptoBot)
Apache License 2.0
1.97k stars 739 forks source link

Fix: missing Coinbase exchange in Telegram Bot and minimum quote order #840

Closed mominafiz closed 7 months ago

mominafiz commented 7 months ago

Description

The Telegram bot doesn't display 'Coinbase' as the exchange and it seems it was intentionally left out due to an error in minimum_order_quote(). Reading the base_min_size in the response of the product API call fixes the issue and the bot starts successfully. The orders are placed for both buy and sell, though there is another uncaught exception that exits the bot. It is related to _trading_data used before initialization which is out-of-scope of this change.

Partially Fixes #832

Type of change

Please make your selection.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

whittlem commented 7 months ago

@mominafiz, thanks for your update.