search

whiver / nifi-protobuf-processor

An Apache NiFi processor to encode and decode data using Google Protocol Buffer schemas.
MIT License
36 stars 20 forks source link

Develop #4

Closed benyaa closed 4 years ago

benyaa commented 5 years ago

I've changed the ProtobufProcessor into AbstractProtobufProcessor so it would fit the convention. I would have changed the processors' names(to EncodeProtobuf & DecodeProtobuf) so they would too but then the API would be changed too. I've also added a property for a default message type and changed the schema setup to onScheduled so it would be possible to evaluate it using expression language. I've added documentation to the processors so it would be clear how to use them.

Hope it would be good enough for you to take it :)

codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into develop will increase coverage by 1.12%. The diff coverage is 85.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #4      +/-   ##
===========================================
+ Coverage    60.48%   61.61%   +1.12%     
===========================================
  Files           12       12              
  Lines          205      211       +6     
  Branches        17       16       -1     
===========================================
+ Hits           124      130       +6     
  Misses          70       70              
  Partials        11       11
Impacted Files Coverage Δ
.../github/whiver/nifi/processor/ProtobufEncoder.java 48.57% <75%> (-1.43%) :arrow_down:
.../github/whiver/nifi/processor/ProtobufDecoder.java 45.94% <80%> (-1.28%) :arrow_down:
...iver/nifi/processor/AbstractProtobufProcessor.java 83.82% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f82fb71...fc78e25. Read the comment docs.

whiver commented 4 years ago

Hi @benyaa, sorry for taking that long to answer you and thanks for your PR! I don't personally use this project anymore so I kind of forgot about it ☹ I'll merge it in develop right away, but even if it looks good to me, I can't really merge it into master before I manually test it and update the docker image. Thanks again!