search

whizkydee / dropd

⚡️Zero-dependency minimalistic dropdown component for React and Vue.
https://npm.im/dropd-component
MIT License
73 stars 15 forks source link

Write unit tests for both packages #4

Closed whizkydee closed 5 years ago

samie820 commented 5 years ago

Hi, I'm pretty new to contributing to monorepos, but I'll like to work on this feature for the React project

whizkydee commented 5 years ago

Hey @samie820,

That's great! It's nothing really crazy, I left some instructions in the Contributing section, feel free to take a look and let me know if you expereince any problems.

samie820 commented 5 years ago

thanks...followed the instructions, I was having issues with yarn install -W, ended up adding a private: true property to the package.json (read it on the yarn docs BTW). Also, if i'm setting up jest, do I install it in the react-dropd package?

whizkydee commented 5 years ago

Perfect! No need to install it in react-dropd. Yarn workspaces and lerna manage that. So, just install it in dropd.

samie820 commented 5 years ago

Oh cool, thanks

whizkydee commented 5 years ago

Hey @samie820! Please checkout the new codebase. A lot has changed, including bug fixes and browser inconsistency fixes.

samie820 commented 5 years ago

Ok will do, I was about to make a PR, but let me check out the changes

whizkydee commented 5 years ago

Thanks for the work on this @samie820, I just merged to master, and published as v1.1.1 with a bunch of nice changes.

I've been really busy lately... at the same time, I've been thinking of the best way to test these components, and I'm glad to announce that I've found just the right solution -- Cypress!

I'll start the setup and migration this week and most likely publish with support for slots -- #3.