search

whizzosoftware / WZWave

A native Java library for interfacing with Z-Wave PC controllers
Eclipse Public License 1.0
33 stars 22 forks source link

Add support for Indicator Command Class #39

Closed eperott closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 62.575% when pulling a497a3d5dbfb7434710ce7aad47ef0b2b55e0637 on eperott:indicator_cc into b9dfec6b55515226edf9d772a89933b336397501 on whizzosoftware:master.

whizzosoftware commented 5 years ago

Thanks for the submission! Could you create a unit test for this (especially the isOn() method?) Thanks!

eperott commented 5 years ago

Thanks for the submission! Could you create a unit test for this (especially the isOn() method?) Thanks!

Sure, np. Would you mind if I bring in a couple of new test dependencies into the project? I'm proposing Mockito for mocking, and assertj for fluent asserts.

whizzosoftware commented 5 years ago

Sure, np. Would you mind if I bring in a couple of new test dependencies into the project? I'm proposing Mockito for mocking, and assertj for fluent asserts.

Absolutely, feel free to add them.