search

whizzosoftware / WZWave

A native Java library for interfacing with Z-Wave PC controllers
Eclipse Public License 1.0
33 stars 22 forks source link

Configuration command class #9

Closed Brimstedt closed 7 years ago

Brimstedt commented 7 years ago

Gave a go at creating ConfigurationCommandClass to set and retrieve settings.

Seems to work, but a bit uncertain about the API for getting values since it's async.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.01%) to 63.701% when pulling b8f6fa2542ecca4b59e5820a16c3b86bbc962b0f on Brimstedt:ConfigurationCommandClass into 8c1d455a4da9988de13007d2d320b496f92d4db7 on whizzosoftware:master.

whizzosoftware commented 7 years ago

This seems like a great start. I saw in the command class specification that it recommends probing the node during the interview process to determine what configuration behavior is supported (page 156 of specification A-M). What they suggest seems a bit heavy and could potentially overwrite configuration values but I might be missing something and need to understand it better. Let me know if it makes more sense to you :-)

whizzosoftware commented 7 years ago

Hi Linus, did you revert this change? I did a merge but it's not showing up and I see something in the history about reverting commits.

Brimstedt commented 7 years ago

Hi, Thanks for accepting my pull requests!

The revert was a mistake, I'll look through all my pms and check what went wrong... I'll read that section on the configuration class again too!

L