search

whizzzkid / bing-wallpapers-for-linux

This enables bing wallpaper on linux, specifically debian based distros.
https://launchpad.net/~whizzzkid/+archive/ubuntu/bingwallpaper
77 stars 30 forks source link

The .desktop file gets messy with updates #4

Closed ghost closed 7 years ago

ghost commented 7 years ago

Because of the >> here, the file ~/.config/autostart/bingwallpaper.desktop becomes messy after a few updates:

[Desktop Entry]
Type=Application
Exec=sh /usr/bin/bingwallpaper
Hidden=false
NoDisplay=false
X-GNOME-Autostart-enabled=true
Name=Bing Wallpaper
Comment=Bing Pic of the day as wallpaper.
[Desktop Entry]
Type=Application
Exec=sh /usr/bin/bingwallpaper
Hidden=false
NoDisplay=false
X-GNOME-Autostart-enabled=true
Name=Bing Wallpaper
Comment=Bing Pic of the day as wallpaper.
# ...

Another point, this file is owned by root:root but sits in user land, that's incorrect I think.

PS: :+1: for this tool, I really like it.

whizzzkid commented 7 years ago

I should remove the desktop entry, This should resolve it.

For some reason on mint, It shows me as the owner of this file. I never wondered that it should show this file to be owned by root. Lemme dig deeper on this.

Thanks :-)

ghost commented 7 years ago

It's fixed, but I did notice something:

/var/log/syslog.7.gz:Dec 19 06:38:27 xxxxxxxxxxx bingwallpaper.desktop[3842]: /usr/bin/bingwallpaper: 93: /usr/bin/bingwallpaper: Syntax error: "(" unexpected (expecting "fi")

That was causing the autostart process to fail. I think this is because of the sh in the autostart file:

regis@xxxxxxxxxxx:~$ sh /usr/bin/bingwallpaper
/usr/bin/bingwallpaper: 93: /usr/bin/bingwallpaper: Syntax error: "(" unexpected (expecting "fi")

Removing the sh fixed the issue for me

whizzzkid commented 7 years ago

This is fixed now. Closing this issue.