search

who-biz / qwerty-lmdb

LMDB for qwertycoin
Other
2 stars 2 forks source link

lmdb hunter #1

Closed exploshot closed 4 years ago

exploshot commented 5 years ago

hi @who-biz , hunter supports lmdb since 0.19.148 so you can theoretically add it like this:

hunter_add_package(lmdb)
find_package(liblmdb CONFIG REQUIRED)
who-biz commented 5 years ago

IIRC, the standard lmdb implementation drivers differ slightly from the drivers included for XMR/BLUR/QWC. But I could be wrong.

I can double check. If there are no conflicts, I don't see why this couldn't be done. Not sure if it adds additional overhead beyond what is built within the QwertycoinFramework::LMDB library, though.

who-biz commented 5 years ago

One other thing to consider @exploshot, would be dependency attacks, or simply inadvertent changes, that may cause nodes to re-interpret historical transaction data erroneously. Pretty sure these kind of things are why unbound, rapidjson, lmdb, and boost (serialization-related) files are ported in as static submodules or built in-tree.

But, whatever you, Xecute, and the other devs would like to do outweighs my opinion on the matter.

who-biz commented 5 years ago

You'll notice that I removed hunter from this repository for the time that I am working. I felt it was excessive to build boost from source each time, when it could be found on the compiler's host system. So maybe a change best left for once the integrations are finished, at any rate.

who-biz commented 5 years ago

@exploshot i'll give the lmdb package a try today, since i'm debugging issues w/ the DB drivers, anyway