who-icatx / whofic-models

Information models used to represent artifacts for WHO-FIC classifications
0 stars 0 forks source link

Remove outdated entries from metamodel.yaml #19

Open tudorache opened 3 weeks ago

tudorache commented 3 weeks ago

From metamodel.yaml, it seems we don't need:

-synonym (which is modeled there as an annotation property):

synonym:
    subproperty_of: baseIndex
    range: BaseIndexTerm
    multivalued: true
    implements:
      - owl:AnnotationProperty

Is permissibleValues still needed?

enums:
  IndexType:
    implements:
      - owl:NamedIndividual
    description: types of index terms
    permissible_values:
        Synonym:
        Narrower:

Maybe there are other cases, as well.

samsontu commented 3 weeks ago

I added "synonym" property because, in the current iCAT, ICD extension codes, ICHI, and ICF's "Title & Definition" page all have a widget for adding synonyms.

PermissibleValues are still needed if we want to acquire synonyms and narrower terms together, right?

samsontu commented 3 weeks ago

Should ICD extension codes, ICHI, and ICF's "Title & Definition" form all have a widget for adding synonyms? The "Term" forms for these entities also have Base Index Terms. Therefore, the information may be duplicated. Is this something we can clarify with Can? Right now, I made the range of "synonym" BaseIndexTerm, which is not correct unless we can force the indexType to be indexType.Synonym.