search

who-knows-inc / KEA_DAT_DevOps_2024_Autumn

10 stars 22 forks source link

Clarification needed on `POST api/register` Implementation #46

Closed osman-butt closed 1 month ago

osman-butt commented 1 month ago

Description

According to the OpenAPI spec for the POST api/register endpoint, the request body should look like:

OpenAPI Spec

However, the legacy code implementation for the POST api/register route is as follows:

Legacy Code

Questions:

1. Which implementation is correct according to the current requirements?

2. Which implementation is the simulation using?

osman-butt commented 1 month ago

@anderslatif

anderslatif commented 1 month ago

Email is missing in the spec and password2 is optional. It will be sent but it's up to your API to use it or not. I have updated the OpenAPI Spec. Thank you for pointing this out.