whobin / javaemvreader

Automatically exported from code.google.com/p/javaemvreader
Apache License 2.0
1 stars 0 forks source link

PPSE TLV parsing crashes and doesn't application even when successful #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
There is a typo in parseFCIDD() that causes an exception while walking the TLV. 
Additionally, even when parsing is successful, the application is not added to 
the card. See attached patch for details. 

Original issue reported on code.google.com by nikolay....@gmail.com on 22 Aug 2012 at 2:48

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the report and patch. It is really helpful. I have added the patch 
to my local codebase, and will be committing it to googlecode shortly, along 
with a new release.

Original comment by sasc...@gmail.com on 1 Sep 2012 at 9:59

GoogleCodeExporter commented 8 years ago
Thanks for looking into this. Another issue I had while using this (as a 
library) is the KnownAIDList -- it tries to load the XML file in a static block 
and this fails on Android. I don't have a patch, but may be loading/parsing the 
XML file should be optional and more abstracted? For example, Android uses it's 
own XML parsing libraries and static files are stored as assets, so opening 
them requires Android-specific code. You can see how use the library on Android 
here: 

https://github.com/nelenkov/android-se-access

BTW, would you be interested in a patch that parses proprietary MasterCard 
tags, such as on a PayPass card? The library currently doesn't seem to support 
those.

Original comment by nikolay....@gmail.com on 2 Sep 2012 at 5:36

GoogleCodeExporter commented 8 years ago
Fixed in the latest version (0.4.0)

Original comment by sasc...@gmail.com on 17 Nov 2012 at 9:27