[Bug] Musixmatch source doesn’t work with local files

whoeevee / EeveeSpotify

A tweak to get Spotify Premium for free, just like Spotilife

2.17k stars 166 forks source link

[Bug] Musixmatch source doesn’t work with local files #338

Closed diow142 closed 2 weeks ago

diow142 commented 3 weeks ago

Is this issue appropriate?

[X] I have read the document in its entirety

Is this issue unique to EeveeSpotify?

[X] I was unable to reproduce my issue using the stock Spotify app

Have you searched the existing issues?

[X] This is a unique issue

Describe the bug.

Local files do not have lyrics if using musixmatch, however if using lrclib the local files will have lyrics. I know that musixmatch does have lyrics for these songs as I use lyrics-plus on desktop.

yodaluca23 commented 3 weeks ago

Probably because LRCLIB uses the song name and artist to do a search but MusixMatch uses the Spotify ID if you're listening to local music obviously it won't have a Spotify ID... could probably add a check for if the song is local or not and if so, then do a search using song and artist name on musixmatch, instead of Spotify ID...

ElliotCHEN37 commented 2 weeks ago

https://developer.musixmatch.com/documentation/api-reference/track-lyrics-get Musixmatch uses a track id

ElliotCHEN37 commented 2 weeks ago

though, you still can get lyrics without track id (using artist and title) https://github.com/fashni/MxLRC

whoeevee commented 2 weeks ago

it should work in v4.9

diow142 commented 2 weeks ago

Can confirm it does work