whoeevee / EeveeSpotify

A tweak to get Spotify Premium for free, just like Spotilife
2.4k stars 185 forks source link

[Bug] Lrclib has synced lyrics but eeveespotify is not using it and also eeveespotify is using the wrong lyrics #411

Closed Diowboss closed 6 days ago

Diowboss commented 6 days ago

Is this issue appropriate?

Is this issue unique to EeveeSpotify?

Have you searched the existing issues?

Describe the bug.

IMG_0810 (what eeveespotify is showing) Screenshot 2024-09-29 at 01-53-50 LRCLIB (what lrclib has)

IMG_0811 (eevee spotify using wrong lyrics) Screenshot 2024-09-29 at 01-54-45 LRCLIB (the actual lyrics) Screenshot 2024-09-29 at 01-56-35 LRCLIB (the wrong song its pulling the lyrics from) Screenshot 2024-09-29 at 01-56-33 LRCLIB (song its supposed to be pulling the lyrics from)

My best guess is that the lrclib api has changed.

Diowboss commented 6 days ago

the reason actually might be that eeveespotify is not using the "album_name" parameter to look up lyrics

whoeevee commented 6 days ago

The LRCLIB API hasn't changed, but you may sometimes see wrong lyrics due to how the tweak searches for songs. EeveeSpotify searches for songs by their name and primary artist, generally picking the first matching result. In one case, there were two identical songs on LRCLIB, and the first one didn’t have synced lyrics, which seems to be resolved now. In another case, there are tracks with the same title and even part of the same artist name, "wonder", but a different one is more popular and selected first. I believe that's rare anyway and only affects a few songs.

Diowboss commented 6 hours ago

for the spicetify plugin “lyrics plus” it doesn’t have the second issue