search

whoisjunhong / pe

0 stars 0 forks source link

Address allows for random characters to be added #10

Open whoisjunhong opened 2 years ago

whoisjunhong commented 2 years ago

Context: Mallicious users can add arbitary text through address

image.png

soc-pe-bot commented 2 years ago

Team's Response

what if the person is from another country and does not use alphabet in their address, that is why we never limit address to only accept alphabets. We suppose to accept special char. For example:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Even in a country that arabic speaking countries such as bahrain or saudi arabia, all address would come with both english and arabic addresses. However, giving a rationale that an address would have mostly arabic name does not hold any weight since the examples below show that even a country saudi arabia does have an english address to follow international standard. image.png

image.png

Moreover, CS2103T is a english speaking and written module, where we follow international standards of addresses. For example, you do not expect a person from a non-arabic country such as Singapore to type in a language that they do not understand in order to send the package to a arabic speaking country, Hence, why arabic speaking countries provide an english alternative to their addresses. So a validation is needed to prevent malicious attackers or trollers from entering non special characters.