search

whoisjunhong / pe

0 stars 0 forks source link

Allows for email name to be anything after @ and domain #8

Open whoisjunhong opened 2 years ago

whoisjunhong commented 2 years ago

Context: Only validates @ and domain name, but anything subsequently after that does not validate. Would be good to limit to 2 fullstops

image.png

nus-pe-script commented 2 years ago

Team's Response

yea you are correct. but what if people got this kind of email address. Some websites provide customized email addresses. It is hard to judge what is the correct email and what is the wrong email address.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I think you cannot assume that people would use your application properly, as developers, we should ensure that the user encounters the least amount of bugs possible and to guide them to our ideal input. If a validation is set it would benefit the user alot. However, this allows for the user to enter whatever they want and for example in the future if you have a email cron job running, these invalidated emails you allowed to be in your system would not be sent out to the correct user or be bounced back. Hence causing more issues for both the user and the system admins.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: It will cause occasional inconvinience if the user entered their email wrongly without validation and does not know that the email they entered is invalid due to the application not prompting them that it is wrong.