search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Logout clears local storage including lastRead value #490

Open craig-willis opened 5 years ago

craig-willis commented 5 years ago

This only happens to me intermittently in non-private sessions, but we are explicitly clearing out local storage during logout:

https://github.com/whole-tale/dashboard/blob/master/app/services/user-auth.js#L50-L68

For the new notification implementation, this means that the lastRead value is cleared on logout, resulting in the display of all notifications after logout.

Perhaps we could either clear everything except lastRead or consider adding lastRead to the user object?

ThomasThelen commented 5 years ago

Probably related to #29. I like the idea of not clearing it on the logout.