search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Instance polling during Tale startup no longer functions as expected #531

Closed bodom0015 closed 4 years ago

bodom0015 commented 4 years ago

In all cases, instance polling appears to no longer function.

Steps to Recreate:

  1. Create and Launch a Tale OR Launch a Tale from Browse OR Launch a Tale from Run
    • You should be routed automatically to the Run view
  2. While the Tale is starting, open the Dev Console to the Networks tab

Expected Behavior: You should see a request to GET /instance/:id every second or two.

Actual Behavior: You won't see any GET /instance/:id requests, so the view never updates unless the user navigates.

bodom0015 commented 4 years ago

Digging into this, it looks like we are checking for modelType instead of _modelType: https://github.com/whole-tale/dashboard/blob/master/app/services/api-call.js#L504

It is unclear why this behavior has changed, but it seem like the poller can't start polling if it doesn't know which endpoint it needs to poll.

bodom0015 commented 4 years ago

Fixed by #534