search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Fix instance popout link on Run > Interact #535

Closed bodom0015 closed 4 years ago

bodom0015 commented 4 years ago

Problem

Popout (aka "open in new tab") link is broken on Run > Interact. It appears to be looking at the wrong value to get the instance.url.

Fixes #533

Approach

Use model.instance.url instead of model.url. Whoops.

How to Test

Prerequisites: LIGO Tutorial Tale registered

  1. Checkout and run this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Run the LIGO Tutorial Tale - you will need to "Copy and Launch" to start this
    • You should be brought to the Run > Interact view while your Tale is starting
  4. Wait for the Tale to start
  5. At the top-right, click the popout button (external link icon)
    • You should see your Tale open in a new tab (instead of an iframe)