search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Reset Select Data modal when clicking Cancel #544

Closed bodom0015 closed 4 years ago

bodom0015 commented 4 years ago

Problem

When clicking Cancel on the Select Data modal, the user's selection is not cleared. The next time the user opens the modal, their previously-added data is still present. This could cause confusion.

Fixes #539

Approach

When opening the modal, parse the Tale's dataSet list and explicitly set that as the content of the modal.

How to Test

  1. Checkout and run this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Navigate to the "Run > Files" view for a Tale
  4. On the left side, click the External Data nav
  5. At the top-right, click the (+) button
    • The Select Data modal should open
  6. Add some new datasets, then click "Cancel"
    • The modal should dismiss
    • The datasets listed in the directory-browser on the Run > Files view should not have changed
  7. At the top-right, click the (+) button
    • The Select Data modal should open again
    • You should no longer see the datasets that were added then cancelled
    • The modal should only show datasets that are already added to the Tale