whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Disable (+) button on Run > Files when Tale is readonly #545

Closed bodom0015 closed 4 years ago

bodom0015 commented 4 years ago

Problem

In the Run > Files view for read-only Tales, the (+) button is still enabled. This could lead the user to believe that they can freely add files, although the API operations themselves will fail due to permissions errors.

Fixes #541

Approach

Disable the (+) button when the Tale is not writable. There is logic already there for this, but it was unclear why it no longer functions.

How to Test

Prerequisites: Register the LIGO Tale (or another read-only public Tale)

  1. Checkout and run ths branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Navigate to the Run > Files view for the LIGO Tale
  4. On the left side, click the Home nav
    • You should see the (+) button at the top-right is enabled
  5. On the left side, click the External Data nav
    • You should see the (+) button at the top-right is disabled
  6. On the left side, click the Tale Workspace nav
    • You should see the (+) button at the top-right is disabled