search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Adjust z-index on error message. Fixes #555 #558

Closed Xarthisius closed 4 years ago

Xarthisius commented 4 years ago

Additionally this removes obsolete "Export as Zip" and changes wording from "Read the Docs" to "Learn More".

Xarthisius commented 4 years ago

@bodom0015 if there's a z-index value that's "above" Tale cards, but "below" everything else I can use it :)

bodom0015 commented 4 years ago

The default z-index value of all the elements on a web page is auto, which corresponds to 0 where no z-index is assigned.

Since the notification-stream doesn't currently explicitly set the z-index, it uses auto == 0 for the value. The log viewer modal uses z-index: 1001 (along with likely most/all Semantic modals). We could probably assign z-index: 1000 to the notification-stream as long as it wouldn't break anything else.

Xarthisius commented 4 years ago

The default z-index value of all the elements on a web page is auto, which corresponds to 0 where no z-index is assigned.

Since the notification-stream doesn't currently explicitly set the z-index, it uses auto == 0 for the value. The log viewer modal uses z-index: 1001 (along with likely most/all Semantic modals). We could probably assign z-index: 1000 to the notification-stream as long as it wouldn't break anything else.

Since it affects pieces of code outside of this PR, I'm inclined to merge this and fix notification stream in a separate PR.