Closed bodom0015 closed 4 years ago
This looks fine to me. I did note a number of styling differences between the implementation and the mockup, but maybe this is due to us being behind several versions on Kristina's styling. What I noticed:
Also, the dashboard failed to load because of a missing session route, which I resolved by merging user-settings-additional-accounts-view
.
I am working off of https://wholetale.org/wholetale-css-mockup/src/settings.html, which I was recently told was the most up-to-date version of the mockups, and ignoring obvious differences like the background color.
Regarding your final note, sorry about that - I seem to have forgotten just how fragile Ember is...
Sounds good. I'm not overly concerned about the styling, but did want to capture the noticed differences. Functionally all is good.
Closing this PR in favor of #563, since merging this would break the dashboard anyways.
All PR feedback has been addressed here, and those changes have been merged into the branch from #563.
Problem
The mockups show a dropdown at the top-right of the navbar, but we currently have separate items. To add upcoming functionality, we should consolidate these navbar options.
Fixes #559
Approach
Replace "Logout" and User Gravatar items in the navbar with a more scalable dropdown menu.
How to Test