Configure DataONE additional account

whole-tale / dashboard

Whole Tale Dashboard

http://wholetale.org

MIT License

7 stars 2 forks source link

Configure DataONE additional account #573

Closed craig-willis closed 4 years ago

craig-willis commented 4 years ago

As noted in https://github.com/whole-tale/dashboard/pull/563, "DataONE is present, but not yet functional".

[x] Connect additional accounts page displays DataONE providers (e.g., DataONE staging) (done)
[x] User selects "Connect" button and is redirected through ORCID flow. As a result, DataONE token is stored in otherTokens
[x] User selects "Disconnect" and token/configured account information is removed.
[x] Callback to Girder with the DataONE JWT when a preauthorized token is detected.

craig-willis commented 4 years ago

Per 12/2 dev call, we're likely not handling the DataONE flow correctly in the UI. See https://github.com/whole-tale/girder_wholetale/pull/364#issue-331121398 DataOne section

bodom0015 commented 4 years ago

As written, the first 3 checkboxes above absolutely were fulfilled by #563. I've added a 4th that highlights the functionality that still needed to be added. The missing piece was apparently, as you had mentioned, that the callback to Girder that wasn't in the test case when I started reviewing that PR.

In any case, I've created a PR to add the missing logic for Connecting a DataONE account via the Dashboard