whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

"Authorized on" links in User Settings have incorrect target URL #581

Closed bodom0015 closed 4 years ago

bodom0015 commented 4 years ago

The "User Settings" view offers users a way to connect external API tokens to their account for consumption and integration within WholeTale. After authorizing a provider with a particular resource_server value, the UI is supposed to offer a link to that resource_server.

Unfortunately, since the resource_server values received from Girder do not include a protocol, the browser interprets them as a relative path, and appends them to the end of the dashboard URL.

Steps to Reproduce

  1. Login to the WholeTale Dashboard
  2. Navigate to the "User Settings" view
  3. Connect a Dataverse or Zenodo account, if you haven't already
    • You should see "Authorized on _____" appear below the Dataverse or Zenodo provider, where ____ is a link to the resource_server
  4. Click the on the link offered by the "Authorized on _____" line

Expected Results Browser should open a new tab to https://demo.dataverse.org or https://sandbox.zenodo.org

Actual Results Browser instead opens a new tab to https://dashboard.local.wholetale.org/demo.dataverse.org or https://dashboard.local.wholetale.org/sandbox.zenodo.org