search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Fixed hard-coded dashboard.local link in provider redirect #589

Closed bodom0015 closed 4 years ago

bodom0015 commented 4 years ago

Problem

A hard-coded value for https://dashboard.local.wholetale.org/settings was left in the controller for the User Settings view. This obviously will not work in production.

Approach

Replace the hard-coded hostname with config.wholeTaleHost instead. This value is populated from an environment variable using sed when the Ember dashboard is built.

How to Test

  1. Checkout and run this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Navigate to the "User Settings" view
  4. Connect an OAuth or DataONE provider
    • After authenticating/authorizing, you should be redirected back to the dashboard