Enable import notifications

whole-tale / dashboard

Whole Tale Dashboard

http://wholetale.org

MIT License

7 stars 2 forks source link

Enable import notifications #592

Closed Xarthisius closed 4 years ago

Xarthisius commented 4 years ago

This PR adds support for generic Girder progress notification for import_tale and import_binder tasks. It depends on https://github.com/whole-tale/girder_wholetale/pull/389

How to test?

Deploy along with https://github.com/whole-tale/girder_wholetale/pull/389
Follow test plan from https://github.com/whole-tale/girder_wholetale/pull/389

Xarthisius commented 4 years ago

So you can use Create New Tale (without launching) to save yourself a lot of time.

My kindred spirit! Let's take the revolution a one step further and make it a default action in the modal!

craig-willis commented 4 years ago

As discussed, even after make clean & make dev I'm seeing odd behaviors. I usually see two notifications, one starting as Building image that eventually renames to Import Tale from external dataset and then the second notification never completes. Here's a recent state, with a phantom third notification. These go away on refresh: